Cache font metrics during redraw to reduce Unicode TUI stalls#292
Merged
Conversation
Collaborator
|
Thanks for the PR. This is a good improvement and I think we should merge it. Long term, I think it's even better to cache the scaling per glyph but I can take it upon me to implement that, this at least improves the immediate case. |
Collaborator
|
LGTM. @dakra Any concerns? |
Owner
|
lgtm. I'll simplify the to temproarily disable garbage collection. So think the same is fine for us and we don't need 2 more defcustoms. |
6cc1e41 to
056d5e9
Compare
Owner
|
Merged. Thanks ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This reduces redraw stalls for Unicode-heavy TUIs such as
btopby avoiding repeatedquery-fontcalls for the same font during a single Ghostel redraw.Fixes #291
Changes
ghostel--query-font-cached, dynamically backed by a redraw-local hash table.ghostel--delayed-redraw.ghostel--query-font-cachedinstead ofquery-font.gc-cons-thresholdandgc-cons-percentageonly while rendering a frame.query-fontcache.Why
Profiling a
btopsession showed redraw spending significant time in repeated Emacs font metric queries and automatic GC. A single redraw could callquery-fontthousands of times for repeated fonts.This patch keeps existing glyph adjustment behavior intact. It intentionally does not skip
font-atorfont-get-glyphs, because an attempted default-font fast path caused visible TUI border artifacts.Validation
zig fmt src/Renderer.zig src/emacs.zigmake .build/tests/elisp-ghostel-glyph-kitty-test.okmake .build/tests/native-ghostel-glyph-kitty-test.okManual validation:
btopat100msupdate interval remains responsive.