Add custom :unexceptional-status option#451
Merged
dakrone merged 1 commit intodakrone:3.xfrom May 29, 2018
Merged
Conversation
Owner
|
Merged this, thanks @mrichards42! I think this is useful! |
dakrone
pushed a commit
that referenced
this pull request
Jun 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have come across a couple of cases where I need to customize which http status codes are considered exceptional but don't need to do anything else with the response. This PR allows passing a custom
:unexceptional-statusfunction in the request, as a way to handle these cases (instead of passing{:throw-exceptions false}and handling exceptions yourself).