Update demo-controller to use papa above the fold style #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalelotts
added a commit
that referenced
this pull request
Nov 20, 2015
chore(demo-controller): Update demo-controller to use papa above the fold style. * Favor function declaration over function expression. https://github.com/johnpapa/angular-styleguide#style-y034 * All functions are exposed on the scope bindable elements but if any of them are purely internal they should, be removed from the scope. * Wrapped with iffe https://github.com/johnpapa/angular-styleguide#style-y010 * Coded the injector directly. The real ideal would be a build step that leverages the gulp-ng-annotate plugin to add the injector statement at build time. I took a quick look but didn't see a step to wire it to so manually wrote the inject. https://github.com/johnpapa/angular-styleguide#style-y091
dalelotts
added a commit
that referenced
this pull request
Nov 20, 2015
… the fold style. Merge pull request #246 from dalemanthei/develop * Favor function declaration over function expression. https://github.com/johnpapa/angular-styleguide#style-y034 * All functions are exposed on the scope bindable elements but if any of them are purely internal they should, be removed from the scope. * Wrapped with iffe https://github.com/johnpapa/angular-styleguide#style-y010 * Coded the injector directly. The real ideal would be a build step that leverages the gulp-ng-annotate plugin to add the injector statement at build time. I took a quick look but didn't see a step to wire it to so manually wrote the inject. https://github.com/johnpapa/angular-styleguide#style-y091
dalelotts
added a commit
that referenced
this pull request
Nov 20, 2015
… the fold style. Merge pull request #246 from dalemanthei/develop * Favor function declaration over function expression. https://github.com/johnpapa/angular-styleguide#style-y034 * All functions are exposed on the scope bindable elements but if any of them are purely internal they should, be removed from the scope. * Wrapped with iffe https://github.com/johnpapa/angular-styleguide#style-y010 * Coded the injector directly. The real ideal would be a build step that leverages the gulp-ng-annotate plugin to add the injector statement at build time. I took a quick look but didn't see a step to wire it to so manually wrote the inject. https://github.com/johnpapa/angular-styleguide#style-y091
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be no change to functions or code.
Favor function declaration over function expression. https://github.com/johnpapa/angular-styleguide#style-y034
All functions are exposed on the scope bindable elements but if any of them are purely internal they should, be removed from the scope.
Wrapped with iffe https://github.com/johnpapa/angular-styleguide#style-y010
Coded the injector directly. The real ideal would be a build step that leverages the gulp-ng-annotate plugin to add the injector statement at build time. I took a quick look but didn't see a step to wire it to so manually wrote the inject. https://github.com/johnpapa/angular-styleguide#style-y091