Added custom aliaser for shared_ptr messages.#64
Merged
dallison merged 1 commit intodallison:mainfrom May 1, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added custom aliaser for shared_ptr messages.
This is basically to support using the shared_ptr directly when trying to tie together the ref-counting/life-time of active-messages with a zero-copy message type that aliases the message memory in some non-trivial way (not just a reinterpret-cast).
The only change for prior behavior is the static assert and sizeof assert on what was originally a blind
reinterpret_castto provide at least some minimal checks against UB.One question is whether it's worth doing a similar mechanism on the publishing side. But that can be a lot trickier (reallocations and all that), while being much easier to do manually (no need for ref-counting and all that). So, I'm leaning towards not doing it on that side of things.