Fix overflowDivider signal invocation in alpha component#323
Merged
damiant merged 2 commits intoui-improvementsfrom Feb 1, 2026
Merged
Fix overflowDivider signal invocation in alpha component#323damiant merged 2 commits intoui-improvementsfrom
damiant merged 2 commits intoui-improvementsfrom
Conversation
Merged
Co-authored-by: damiant <3505469+damiant@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP address UI improvements based on review feedback
Fix overflowDivider signal invocation in alpha component
Feb 1, 2026
damiant
added a commit
that referenced
this pull request
Feb 1, 2026
* refactor: replace Ionic's `ion-tab-bar` with a new custom `TabBarComponent`. * Update Capacitor, CapacitorCordova, and CordovaPlugins from version 8.0.0 to 8.0.1. * refactor: Apply consistent code formatting, update component imports, and refine email card date display. * chore: Update ESLint and TypeScript configurations, dependencies, and linting documentation. * refactor: update variable declarations to use const and update iOS dependencies. * chore: Update dependencies, refactor tab bar selected input to use `model`, adjust tab bar styling, and apply minor code formatting. * feat: implement a sliding indicator for the tab bar and adjust related styling and padding. * feat: Add conditional labels to tab bar items and update styling to support their display. * chore: Bump version codes and update marketing version to 2.117 * feat: Enhance accessibility and improve code quality across components * feat: Improve accessibility by adding keyboard navigation and aria attributes across multiple components * feat: Enhance accessibility by adding keyboard navigation to interactive elements and improving code quality * fix: Refactor promise handling in update confirmation to improve readability and maintainability * fix: Update property check in hasValue method for improved reliability * feat: Update component properties to use input signals for better reactivity and performance * feat: Refactor bar and tab-bar components for improved animation and state management * fix: Add dark mode styles for the bar component * fix: Update unread message condition for improved clarity * feat: Enhance messages and favorites UI with improved icon usage and text clarity * chore: update dependencies to latest versions - bump @capawesome/capacitor-app-update from 8.0.1 to 8.0.2 - bump @webnativellc/capacitor-filesharer from 7.0.4 to 7.1.0 - bump @webnativellc/capacitor-print-webview from 7.0.1 to 7.1.0 - bump three from 0.181.1 to 0.182.0 * chore: update Capacitor and Firebase dependencies to latest versions * fix: remove memory boost note from linting instructions * Fix overflowDivider signal invocation in alpha component (#323) * Initial plan * fix: call overflowDivider signal as function in checkVisibleLetters Co-authored-by: damiant <3505469+damiant@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: damiant <3505469+damiant@users.noreply.github.com> * feat: Improve UI layout and responsiveness for favorites and messages pages * feat: Replace IonBadge with custom app-badge component across multiple pages for improved UI consistency * fix: Adjust ion-icon styling and clean up tab selection emission in TabBarComponent * feat: Enhance tab bar component with improved indicator visibility and responsive styles * refactor: Update home method to set status bar based on theme instead of fixed style * fix: Update @capacitor/filesystem dependency to version 8.1.0 * Add functionality changes to changelog for version 2.117 (#324) * Initial plan * docs: Add functionality changes to changelog.md under version 2.117 Co-authored-by: damiant <3505469+damiant@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: damiant <3505469+damiant@users.noreply.github.com> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: damiant <3505469+damiant@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After converting
overflowDividerto a signal input, thecheckVisibleLettersmethod still referenced it as a property instead of calling it as a function. This pushed function references intovisibleLettersarrays, breaking downstream string operations liketoLowerCase()ingetClosestValidLetterIndex.Changes:
this.overflowDividertothis.overflowDivider()in reduce callbacks💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.