Skip to content

fix: 축하메시지 텍스트 롤링과 이미지 배너 싱크 #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sdk-kr merged 1 commit into from
Mar 7, 2026
Merged

fix: 축하메시지 텍스트 롤링과 이미지 배너 싱크 #310

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions apps/web/src/lib/components/ui/damoang-banner/damoang-banner.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,20 +45,16 @@
// 공유 스토어에서 축하메시지 가져오기
let storeCelebrations = $derived(getCelebrations());
let storeIndex = $derived(getCurrentIndex());
// 이미지 타입만 필터링
let imageCelebrations = $derived(
storeCelebrations.filter((b) => !b.display_type || b.display_type === 'image')
);

// 최종 선택된 배너 (축하메시지 or 프리미엄 광고)
let adsBanner = $state<AdsBanner | null>(null);
let loading = $state(true);
let useFallback = $state(false);

// 텍스트 롤링과 동일한 인덱스 사용 (싱크)
let celebrationBanner = $derived.by<CelebrationBanner | null>(() => {
if (!showCelebration || useFallback || adsBanner) return null;
if (imageCelebrations.length === 0) return null;
return imageCelebrations[storeIndex % imageCelebrations.length] ?? null;
if (storeCelebrations.length === 0) return null;
return storeCelebrations[storeIndex % storeCelebrations.length] ?? null;
});

// position → 다모앙 광고 서버 position 매핑
Expand Down Expand Up @@ -110,7 +106,7 @@
loading = false;
// 축하메시지도 광고도 없으면 GAM 폴백 (스토어 로드 대기)
await new Promise((r) => setTimeout(r, 500));
if (!adsBanner && imageCelebrations.length === 0) {
if (!adsBanner && storeCelebrations.length === 0) {
useFallback = true;
}
} else {
Expand Down
Loading