댓글 이미지 라이트박스 + 알림 스크롤 + 쪽지함 인증 수정#911
Merged
Merged
Conversation
1. #8959 댓글 이미지 라이트박스에 프사 포함 수정: attachLightbox() 셀렉터에 .no-lightbox 제외 + avatar 영역 필터 추가 2. #8894 알림 클릭 시 위치이동 안됨: goto() 후 해시가 있으면 scrollIntoView로 수동 스크롤 3. #8884 쪽지함 로그인 핑퐁: /messages +page.server.ts에 locals.user 체크 추가, 비인증 시 로그인 페이지로 redirect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1. #8959 댓글 이미지 라이트박스에 프사 포함
attachLightbox()셀렉터에.no-lightbox제외 추가.comment-author,.author-info,.avatar-wrapper내 이미지 필터링2. #8894 알림 클릭 시 위치이동 안됨
goto()후 URL에 해시가 있으면scrollIntoView로 수동 스크롤3. #8884 쪽지함 로그인 핑퐁
/messages/+page.server.ts에locals.user체크 추가/login?redirect=/messages리다이렉트Test plan
pnpm check기존 에러 외 추가 에러 없음