forked from apache/airflow
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-6505] Let emoji encoded properly for json.dumps() -- BaseSQ… #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR contains changes regarding AIP-21 (renaming GCP operators and hooks): * renamed GCP modules * adde deprecation warnings to the contrib modules * fixed tests * updated UPDATING.md
The containers were not removed and you have to remove them with `dockery system prune`. The --rm flag is added.
…pable by config option (apache#7096)
…lls (apache#7089) no need for 2 sleep, _processor_poll_interval will already sleep
…7112) PR contains changes regarding AIP-21 (renaming GCP operators and hooks): * renamed GCP modules * fixed tests
Add dag_ids GET parameter to /blocked end point to allow querying of just the dags present on the current page.
… be skippable by config option (apache#7096)" (apache#7129) This reverts commit 77b1bdc. Reverts apache#7096 to do in a slightly different way (without a new config option), and reverting this so that the new change is easier to backport to 1.10 releases.
* [AIRFLOW-6733] Extend, rather than replace, the base_template This commit just moves the existing template to airflow/master.html (without further changes) * [AIRFLOW-6733] Only change blocks we have customized This makes is easier to see which parts of the template we have changed.
…pache#7367) Flask/FAB gives us a `base_template` variable that we should use instead of hard-coding a specific template to extend.
…apache#7371) The logs are now sent in the bash scripts when all tests are complete
If the number of dags was large and/or the length of the DAG ids were too large this would exceed the maximum possible query string limit. To work around that we have made these endpoints always make POST requests
Unknown parameter in input: "Workgroup", must be one of: QueryString, ClientRequestToken, QueryExecutionContext, ResultConfiguration, WorkGroup
…che#7382) This happens when you have shared clone of the repository
…ache#7318) * [AIRFLOW-XXXX] Add explicit info about JIRAs for code-related PRs * fixup! [AIRFLOW-XXXX] Add explicit info about JIRAs for code-related PRs Co-Authored-By: Jarek Potiuk <jarek@potiuk.com> Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
…pache#7393) * [AIRFLOW-6766] Fix "cannot import ensure_text" error for pre-commit As of today Travis bundles six version 1.11.0 with their python 3.6 image and it misses ensure_text method. Bumping to 1.14+ solves the problem.
* Change default wg name * Change workgroup in tests
damon09273
force-pushed
the
fix_emoji_encoding_sql_to_gcs
branch
from
February 11, 2020 07:57
6444656
to
805ff10
Compare
damon09273
pushed a commit
that referenced
this pull request
Feb 11, 2020
…n using job_flow_name and no cluster is found (apache#6898) * [AIRFLOW-6432] fixes in EmrAddStepsOperator fix EmrAddStepsOperator broken ref & faulty test * changes after CR #1 * Add exception and test case * Update airflow/contrib/hooks/emr_hook.py Co-Authored-By: Tomek Urbaszek <turbaszek@gmail.com> * Update airflow/contrib/hooks/emr_hook.py Co-Authored-By: Tomek Urbaszek <turbaszek@gmail.com> * Update airflow/contrib/operators/emr_add_steps_operator.py Co-Authored-By: Tomek Urbaszek <turbaszek@gmail.com> * Update airflow/contrib/hooks/emr_hook.py Co-Authored-By: Tomek Urbaszek <turbaszek@gmail.com> * Update tests/contrib/operators/test_emr_add_steps_operator.py Co-Authored-By: Tomek Urbaszek <turbaszek@gmail.com> * changes after CR apache#2 Co-authored-by: Tomek Urbaszek <turbaszek@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Jira
Description
Emoji can't be encoded properly when
json.dumps()
and 'UTF-8', problem fixed by adding parameterensure_ascii=False
.In line BaseSQLToGoogleCloudStorageOperato.
For example
the emoji 🍻 encoded differentially when in use or not use
ensure_ascii=False
.In Use (correct UTF-8 encode): "\xf0\x9f\x8d\xbb"
Not Use:"\\ud83c\\udf7b"
Ref: https://stackoverflow.com/questions/51183947/python-json-dumps-doesnt-encode-emojis-properly
Tests
Commits
Documentation
Code Quality
flake8
Make sure you have checked all steps below.
Jira
Description
Tests
Commits
Documentation
Code Quality
flake8