General typography and alignment guidelines

[YogiBear12]

As the client is getting more and more mature, I find myself finding less and less reasons to maintain my fork, which is a good thing. The ultimate goal was never to maintain it long term.

At this point, I'm pretty sure my changes are just around the font sizing and placement across screens.
Would you be interested in me sorting out some typography rules to standardize what font styles different types of text should use?

eg.

• Movie Title currently uses headlineMedium on the Home screen, but displaySmall on the Movie Details screen.
• The Recommended tab has a different left padding to the home page
• etc

Happy to PR these changes myself, just work on some guidelines, or ignore it completely if it's not something you want to touch at the moment.

[damontecres]

Would you be interested in me sorting out some typography rules to standardize what font styles different types of text should use?

Yes! I would like the headers on each page to be in the same position (same padding) and use consistent font sizes for title, labels, etc.

I think using the home page header position and font sizes is my preference to use app-wide for headers.

[Pentaphon]

I like it. The movie title was a bit too big and the synopsis didn't need to be indented.

[YogiBear12]

I don't think the overview indentation was intentional. The box containing the overview was actually aligned, but due to the padding on the box, the text itself appeared indented. So I offset the left padding to accommodate and keep everything aligned visually

[damontecres]

I actually prefer the indented overview text. It breaks it up visually just a little bit.

And I don't think there needs to be the added padding between the stream labels and tag line.

[YogiBear12]

Fair enough. The added padding between the stream labels and tag line was to break it up a bit, as it's kind of just a block of text once the overview text was visually aligned. It's all in separate commits in the PR, so feel free to just cherry pick what you do and don't want. I held off on trying to push any of the more radical visual changes I played around with😅

[brh150]

Just to chime in - I agree with @Pentaphon - I really like the changes proposed by @YogiBear12. They're rather small, incremental improvements on top of the great work already done by @damontecres, but IMHO they noticeably improve visual consistency.

The indented overview text always felt slightly off... As for the added padding between labels and the tagline - it gives nice separation between technicalities and description and it just feels more balanced, especially when compared to the spacing between the director and the buttons - after the change, the paddings look the same.

[YogiBear12]

@damontecres on a related note, once we've got the movie and series details finalized, I'll apply the new style rules to the episode details as well.

Outside of that, is there anything else you want me to potentially look at?
For example, I've been playing around with a slightly smaller card size of 160dp, and it solves a few visual hiccups.
Eg, that little jump the leftmost card does when you start navigating the row.

And since the cards are a bit smaller, the 8th card is positioned in a way that you could remove the end padding from the row and let it overflow off screen.

I've also been experimenting with using titleMedium instead of titleLarge for the row titles and I think it looks a little nicer.

These three changes bring the content rows closer to how Plex does it, but just a bit smoother since Wholphin's rows are animated and Plex's are not.

[damontecres]

playing around with a slightly smaller card size of 160dp

I know everyone seems to comment that the UI/cards are too big. I'm sorry everyone, but my eyesight is terrible!

But for real, a little bit smaller would be fine, but you might want to wait a few days because I have a major update coming to the home screen.

[Pentaphon]

I'm sorry everyone, but my eyesight is terrible!

That's fine! Your app should look out for such people if you want it to. Accessibility is important! Looking forward to the home screen.

[YogiBear12]

I think I added some end padding so that when scrolled all the way to end the card doesn't expand off screen.

Ah yep, I did see that when I first removed the end padding. The off-screen scroll sort of goes hand in hand with smaller cards, but I'll keep playing around and see if there's a middle ground with the focus modifier.

Looking forward to the home screen update though, so I'll hold off until then

[damontecres]

Here's that home page update: #803

Still a bit of a WIP, but relatively stable.

[YogiBear12]

Solves like 99℅ of the changes I wanted to make 😂