Add relay hints to tags and identifiers #3137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
tyiu
commented
Jul 15, 2025
Comment on lines
-912
to
-913
| if let quoted_ev = state.events.lookup(ev.id) { | ||
| tags.append(["p", quoted_ev.pubkey.hex()]) |
Collaborator
Author
There was a problem hiding this comment.
I actually don't understand this code. Why do a lookup again when we already have the quoted event pubkey? Seems like a bug?
Collaborator
There was a problem hiding this comment.
not sure, looks like an oversight or the result of a refactor. removing it looks fine to me
Changelog-Added: Add relay hints to tags and identifiers Signed-off-by: Terry Yiu <git@tyiu.xyz>
jb55
approved these changes
Jul 16, 2025
Comment on lines
-912
to
-913
| if let quoted_ev = state.events.lookup(ev.id) { | ||
| tags.append(["p", quoted_ev.pubkey.hex()]) |
Collaborator
There was a problem hiding this comment.
not sure, looks like an oversight or the result of a refactor. removing it looks fine to me
danieldaquino
approved these changes
Jul 18, 2025
Collaborator
danieldaquino
left a comment
danieldaquino
left a comment
There was a problem hiding this comment.
Thank you @tyiu, looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds relay hints to tags and identifiers to improve content discovery on the network. Previously, we were referencing identifiers without them, so other clients would need to guess where to look for that content, leading to a broken user experience.
This PR does not take care of all the places that could have relay hints added. It only adds the ones where it's convenient. To fully tackle the rest, we would need a fundamental change in some of the core code.
Checklist
Closes:orFixes:tags in the commit messages wherever applicable, or made sure those are not needed. See Submitting patchesTest report
Device: iPhone 16 Pro Simulator
iOS: 18.5
Damus: 96cd6dc
Steps:
...menu, and tapCopy note ID.neventinstead of anote1identifier now.neventidentifier into search and observe that note appear.Copy Link.nevent. This has not changed, but the selection of relays now prefers actual relays that we found the event from first.Share Linkinstead.Results: