feat(docker): add stable tag #360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-online
force-pushed
the
feat/stable-docker-tag
branch
from
52309ea to
26a2136
Compare
Deploying autopulseui with
|
| Latest commit: |
8d61be1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8ef59fee.autopulseui.pages.dev |
| Branch Preview URL: | https://feat-stable-docker-tag.autopulseui.pages.dev |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a "stable" tag for Docker images when releasing a new version, allowing users to always pull the latest stable release without needing to specify version numbers.
- Adds
tag_stable=stableoutput variable to tag generation steps for release builds - Updates Docker image tagging to include stable tags alongside version-specific tags
- Implements stable manifest creation and pushing for both GHCR and Docker Hub registries
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+249
to
267
| ${{ steps.tag.outputs.tag_stable && format('danonline/autopulse:{0}{1}', steps.tag.outputs.tag_stable, matrix.platform.tag) || '' }} | ||
| labels: ${{ steps.meta.outputs.labels }} |
There was a problem hiding this comment.
Empty strings in the tags list may cause issues with Docker buildx. Consider using a conditional block structure instead of inline conditionals that can produce empty strings.
Comment on lines
+265
to
283
| ${{ steps.tag.outputs.tag_stable && format('danonline/autopulse:{0}-{1}{2}', steps.tag.outputs.tag_stable, matrix.feature, matrix.platform.tag) || '' }} | ||
| labels: ${{ steps.meta.outputs.labels }} |
There was a problem hiding this comment.
Similar to the previous issue, empty strings in the tags list may cause problems. Consider restructuring to avoid potential empty tag entries.
dan-online
force-pushed
the
feat/stable-docker-tag
branch
from
26a2136 to
f6d9efd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #358
Type of change