fix: WhatsApp auth - command injection, wrong endpoint, 422 handling#1
Merged
dandaka merged 3 commits intodandaka:mainfrom Mar 17, 2026
Merged
Conversation
Replace shell-interpolated exec() with Bun.spawn() using argv array and stdin Blob. QR data from the WAHA HTTP response no longer passes through a shell, preventing injection via crafted QR values.
WAHA returns 422 (not just 409) when a session is already running. Treat both as non-fatal so the auth flow continues to QR display.
Use /api/{session}/auth/qr?format=raw instead of the non-existent
/api/sessions/{session}/auth/qr path. Matches current WAHA API docs.
Owner
|
Thanks @greirson! Clean fixes all around — the command injection fix is especially important. Merging. |
Owner
|
by the way did you able to test WA integration? I have drafted the implementation, but has not connected yet :) |
This was referenced Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exec()withBun.spawn()using argv array and stdin Blob. QR data from WAHA HTTP response no longer passes through a shell./api/{session}/auth/qr?format=rawinstead of non-existent/api/sessions/{session}/auth/qr.Test plan
bun testpasses (138 tests, 0 failures)