Skip to content

Remove use of Python 3.9 in tests against dandi-cli#359

Merged
yarikoptic merged 1 commit intomasterfrom
drop-39-in-cli-tests
Dec 15, 2025
Merged

Remove use of Python 3.9 in tests against dandi-cli#359
yarikoptic merged 1 commit intomasterfrom
drop-39-in-cli-tests

Conversation

@candleindark
Copy link
Member

As of dandi/dandi-cli#1759, dandi-cli has drop support of Python 3.9, so testing against dandi-cli in a Python 3.9 environment is no longer relevant and causes the following error.

Screenshot 2025-12-08 at 5 23 22 PM

This PR removes the use of Python 3.9 in integration tests against dandi-cli.

@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.89%. Comparing base (f6e5aa6) to head (a1a4783).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #359   +/-   ##
=======================================
  Coverage   97.89%   97.89%           
=======================================
  Files          18       18           
  Lines        2377     2377           
=======================================
  Hits         2327     2327           
  Misses         50       50           
Flag Coverage Δ
unittests 97.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the dandi-cli integration test workflow to remove Python 3.9 support, aligning with dandi-cli's recent decision to drop Python 3.9 in their PR #1759.

Key Changes:

  • Removed Python 3.9 from the test matrix includes
  • Updated dandi-devel test entries to use Python 3.10 instead
  • Removed obsolete exclude section for Windows + Python 3.9

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@yarikoptic yarikoptic added the tests Add or improve existing tests label Dec 15, 2025
@yarikoptic yarikoptic merged commit 58ccbca into master Dec 15, 2025
77 checks passed
@yarikoptic yarikoptic deleted the drop-39-in-cli-tests branch December 15, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Add or improve existing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants