Skip to content

Fix DANDI User Guide Part I: uncomment a working default dandiset#152

Merged
bendichter merged 1 commit into
masterfrom
fix-dandi-guide-default-dandiset
May 13, 2026
Merged

Fix DANDI User Guide Part I: uncomment a working default dandiset#152
bendichter merged 1 commit into
masterfrom
fix-dandi-guide-default-dandiset

Conversation

@bendichter
Copy link
Copy Markdown
Member

The example-selector cell had all four candidate (dandiset_id, filepath) pairs commented out, so the next cell hit NameError: name 'dandiset_id' is not defined on a run-all-cells. The original intent seemed to be that a user manually edits the cell, but a notebook should still execute end-to-end out of the box (and the next cells in the guide assume dandiset_id/filepath are set).

Verified current asset existence for all four candidates against the live DANDI API:

Dandiset Path Status
000054 sub-F2/sub-F2_ses-20190407T210000_behavior+ophys.nwb gone
000053 sub-npI1/sub-npI1_ses-20190415_behavior+ecephys.nwb gone
000022 sub-744912845/sub-744912845_ses-766640955.nwb exists
000003 sub-YutaMouse41/sub-YutaMouse41_ses-YutaMouse41-150831_behavior+ecephys.nwb gone

Uncommented the 000022 line — the only one that currently resolves. Left the other three commented untouched (they'd need fresh paths from the current dandiset state; out of scope here).

Caught by the headless test sweep of #149.

🤖 Generated with Claude Code

The example-selector cell had all four candidate (dandiset_id, filepath)
pairs commented out, so the next cell hit "NameError: name 'dandiset_id'
is not defined" when run-all-cells. The original intent was that a user
edits the cell, but a notebook should still execute end-to-end out of
the box.

Verified current asset existence for all four candidates against the
DANDI API:

  000054 sub-F2/sub-F2_ses-20190407T210000_behavior+ophys.nwb  -> gone
  000053 sub-npI1/sub-npI1_ses-20190415_behavior+ecephys.nwb   -> gone
  000022 sub-744912845/sub-744912845_ses-766640955.nwb         -> exists
  000003 sub-YutaMouse41/...                                   -> gone

Uncommented the 000022 Allen Institute neuropixel line — the only one
that still resolves. Other three left commented unchanged (separate
PRs would refresh those paths).

Caught by the headless test sweep of #149.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@bendichter bendichter requested a review from h-mayorquin May 12, 2026 22:56
Copy link
Copy Markdown
Contributor

@h-mayorquin h-mayorquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified the four candidates against the live DANDI API and three of the four actually resolve, not one only one 000053/sub-npI1/sub-npI1_ses-20190415_behavior+ecephys.nwb (44.5 GB) and 000003/sub-YutaMouse41/sub-YutaMouse41_ses-YutaMouse41-150831_behavior+ecephys.nwb (14.5 GB) are both still there, alongside 000022 (2.75 GB).

The code change is still good: 000022 is the smallest, so it's a sensible default but the PR description's rationale ("the only one that currently resolves") is incorrect and I am wondering if #149 script might have something or if this was just a fluke on the agent PR description. I think is worth double checking.

@bendichter bendichter merged commit bfbab91 into master May 13, 2026
1 check failed
bendichter added a commit that referenced this pull request May 13, 2026
Brings in 4 recently-merged PRs:

- #150 (Create_manifest pandas import) — auto-merged with bootstrap
- #151 (NWBWidget-demo stale 000054 path) — auto-merged
- #152 (DANDI User Guide Part I default dandiset) — auto-merged
- #154 (codespell ignore 'makin') — auto-merged
- #100 (001172 demo, already Colab-ready via 8fa9feb)

All conflicts auto-resolved by git: each affected notebook has both
master's content fix and #149's bootstrap cells.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
bendichter added a commit to catalystneuro/example-notebooks that referenced this pull request May 13, 2026
Brings the PR branch up to date with recent merges (codespell fix,
Colab-ready notebooks via PRs dandi#100/dandi#150/dandi#151/dandi#152, etc).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants