reproduce_figure1d: bump numpy 1.26 → 2.0 (np.NaN fix is in)#163
Merged
Conversation
The lock generated by PR #159 pinned `numpy==1.26.4` because the PR-141-era input deps included `numpy>=1.26,<2`. That cap was there because the notebook used `np.NaN` (removed in numpy 2.0). PR #156 already replaced `np.NaN` with `np.nan`, so the cap is now stale and the notebook code is numpy-2.x clean. Re-resolved with `numpy>=1.26` (no upper cap) against the Colab constraints set. The only line that changed is the numpy pin — everything else was already at Colab versions: numpy 1.26.4 -> 2.0.2 (matches Colab — no restart on install) Now the install on Colab is fully no-op for numpy/pandas/scipy/h5py/etc. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Contributor
|
Preview for this PR has been removed (PR closed). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #159's regen pinned this notebook to
numpy==1.26.4because the PR-141-era input deps includednumpy>=1.26,<2. That<2cap was there because the notebook code usednp.NaN(removed in numpy 2.0).PR #156 already replaced
np.NaNwithnp.nan— the notebook code has been numpy-2.x clean for a while. The<2cap was just never refreshed in the input deps.Fix
One-line: re-resolved the lock with
numpy>=1.26(no upper cap) against the Colab constraints set. Every other pin was already at Colab versions from #159, so the only line that changed is numpy:Now matches Colab's preinstalled
numpy==2.0.2, so the install cell is a no-op for numpy on a fresh Colab runtime — no kernel restart needed.🤖 Generated with Claude Code