Skip to content

Update open_url test to use self hosted image#1891

Merged
nfahlgren merged 1 commit into
mainfrom
fix-open-url-test
Mar 16, 2026
Merged

Update open_url test to use self hosted image#1891
nfahlgren merged 1 commit into
mainfrom
fix-open-url-test

Conversation

@nfahlgren
Copy link
Copy Markdown
Member

@nfahlgren nfahlgren commented Mar 15, 2026

Describe your changes
Updates the test for open_url to use a self-hosted image. The original test opens an image in GitHub and is now triggering a too many attempts error.

Type of update
Is this a: Bug fix

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@nfahlgren nfahlgren added this to the PlantCV v4.10.3 milestone Mar 15, 2026
@github-project-automation github-project-automation Bot moved this to Pull Requests in PlantCV4 Mar 15, 2026
@deepsource-io
Copy link
Copy Markdown

deepsource-io Bot commented Mar 15, 2026

DeepSource Code Review

We reviewed changes in 12eb31d...f0e8dbf on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Coverage  

Code Review Summary

Analyzer Status Updated (UTC) Details
Python Mar 15, 2026 9:16p.m. Review ↗
Test coverage Mar 15, 2026 9:16p.m. Review ↗

Code Coverage Summary

Language Line Coverage (New Code) Line Coverage (Overall)
Aggregate
100%
[✓ above threshold]
100%
Python
100%
[✓ above threshold]
100%

➟ Additional coverage metrics may have been reported. See full coverage report ↗

@joshqsumner joshqsumner self-requested a review March 16, 2026 12:17
Copy link
Copy Markdown
Contributor

@joshqsumner joshqsumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nfahlgren nfahlgren merged commit 1f0f757 into main Mar 16, 2026
5 checks passed
@github-project-automation github-project-automation Bot moved this from Pull Requests to Done in PlantCV4 Mar 16, 2026
@nfahlgren nfahlgren deleted the fix-open-url-test branch March 16, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants