danger-js: Add DiffForFile method with comprehensive diff parsing, use interfaces to allow mocking #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
solethus
reviewed
Sep 2, 2025
echarrod
changed the title
Add DiffForFile method to Git struct that executes git diff for a specific file. Add FileDiff and DiffLine types to represent parsed diff content. Add comprehensive test suite with 10 test cases covering various diff scenarios. AI::Created
Convert concrete structs (GitHub, GitLab, Settings, Git) to interfaces with clean names and internal implementations (gitImpl, gitHubImpl, gitLabImpl, settingsImpl) to improve testability and mockability while maintaining JSON marshaling compatibility. - Replace GitHubIntf/GitLabIntf/SettingsIntf with clean interface names - Add internal struct implementations with proper method implementations - Create DSLData struct for JSON unmarshaling with ToInterface() conversion method - Update danger-js.go and runner.go to use new unmarshaling pattern - Remove duplicate struct definitions from types_github.go and types_gitlab.go - All tests pass and backwards compatibility maintained 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Convert concrete structs (GitHub, GitLab, Settings, Git) to clean interfaces without suffixes - Add internal implementations (gitImpl, gitHubImpl, gitLabImpl, settingsImpl) for better testability - Create DSLData struct for JSON unmarshaling with ToInterface() conversion method - Update danger-js.go and runner.go to use new unmarshaling pattern - Remove duplicate struct definitions from types_github.go and types_gitlab.go - Extract shared diff parsing logic into parseDiffContent() function to eliminate code duplication - Add DiffForFileWithRefs() method to make git commit references configurable (base/head) - Enhance line number tracking to parse actual line numbers from hunk headers (@@ syntax) - Add proper line number support to DiffLine struct - Maintain backward compatibility with existing DiffForFile() method - Uses strconv.Atoi for robust integer parsing from hunk headers - Tracks separate line counters for added vs removed lines - Line number feature is working correctly (tests show actual vs expected line numbers) - All core functionality implemented per PR feedback requirements 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Remove Claude configuration files and update test expectations to match the correct behavior of parseDiffContent which now properly extracts line numbers from git diff hunk headers. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
echarrod
force-pushed
the
ed-addFileDiff
branch
from
abcb1a9 to
d9989a8
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces Git diff functionality to the danger-js package by adding a DiffForFile method that can parse git diff output for specific files. The changes also restructure the codebase to use interfaces instead of concrete structs, enabling better testability through mocking.
- Add
DiffForFileandDiffForFileWithRefsmethods to the Git interface for executing git diff commands - Introduce
FileDiffandDiffLinetypes to represent parsed diff content with line numbers - Refactor existing structs to implement interfaces (GitHub, GitLab, Git, Settings) to enable mocking in tests
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| danger-js/types_danger.go | Adds interfaces, diff parsing logic, and git diff execution methods |
| danger-js/types_danger_test.go | Comprehensive test coverage for diff parsing functionality |
| danger-js/types_gitlab.go | Removes concrete GitLab struct (moved to types_danger.go as interface) |
| danger-js/types_github.go | Removes concrete GitHub struct (moved to types_danger.go as interface) |
| danger-js/danger-js.go | Updates to use new interface-based DSL structure |
| cmd/danger-go/runner/runner.go | Updates to use new interface-based DSL structure |
| build/ci/dangerfile.go | Updates to use new Git interface methods |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…gnore - Add single and double quotes to dangerous characters list in validateFilePath - Add validateGitRef function to validate baseRef and headRef parameters - Add validation for git references in DiffForFileWithRefs to prevent command injection - Add .claude/settings.local.json to .gitignore to prevent accidental commits
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 8 out of 10 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
andrewwormald
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
DiffForFilemethod to Git struct that executes git diff for a specific fileFileDiffandDiffLinetypes to represent parsed diff content