Skip to content

danger-js: Add DiffForFile method with comprehensive diff parsing, use interfaces to allow mocking #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 23, 2025
Merged

danger-js: Add DiffForFile method with comprehensive diff parsing, use interfaces to allow mocking #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
655f2db
danger-js: Add DiffForFile method with comprehensive diff parsing
echarrod Sep 1, 2025
0381274
danger-js: Convert structs to clean interfaces without suffixes
echarrod Sep 1, 2025
a57acd4
danger-js: Convert structs to clean interfaces and improve diff parsing
echarrod Sep 1, 2025
5967916
danger-js: Fix test expectations for correct line number parsing
echarrod Sep 2, 2025
d9989a8
danger-js: Update dangerfile to use new Git interface methods
echarrod Sep 2, 2025
5a1240e
Delete .claude/settings.local.json
echarrod Sep 9, 2025
8074eb7
danger-js: Address PR review comments - optimize performance and secu…
echarrod Sep 9, 2025
4b9de8c
danger-js: Address PR review comments - improve security and add giti…
echarrod Sep 22, 2025
8dc7590
danger: Extract chars to vars
echarrod Sep 23, 2025
7778632
mr: Address comments
echarrod Sep 23, 2025
566df78
Update danger-js/types_danger_test.go
echarrod Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,6 @@
# Local dev files
/go.work
/go.work.sum

# Claude Code local settings
.claude/settings.local.json
4 changes: 2 additions & 2 deletions build/ci/dangerfile.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@ import (

// Run is invoked by danger-go
func Run(d *danger.T, pr danger.DSL) {
d.Message(fmt.Sprintf("%d new files added!", len(pr.Git.CreateFiles)), "", 0)
d.Message(fmt.Sprintf("%d files modified!", len(pr.Git.ModifiedFiles)), "", 0)
d.Message(fmt.Sprintf("%d new files added!", len(pr.Git.GetCreatedFiles())), "", 0)
d.Message(fmt.Sprintf("%d files modified!", len(pr.Git.GetModifiedFiles())), "", 0)
}
4 changes: 2 additions & 2 deletions cmd/danger-go/runner/runner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ func Run() {
}

var jsonData struct {
Danger dangerJs.DSL `json:"danger"`
Danger dangerJs.DSLData `json:"danger"`
}
err = json.Unmarshal(jsonBytes, &jsonData)
if err != nil {
Expand All @@ -62,7 +62,7 @@ func Run() {
}

d := danger.New()
fn(d, jsonData.Danger)
fn(d, jsonData.Danger.ToInterface())
respJSON, err := d.Results()
if err != nil {
log.Fatalf("marshalling response: %s", err.Error())
Expand Down
6 changes: 3 additions & 3 deletions danger-js/danger-js.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@ func GetPR(url string, dangerBin string) (DSL, error) {
return DSL{}, fmt.Errorf("could not download DSL JSON with danger-js: %w", err)
}

var pr DSL
if err = json.Unmarshal(prJSON, &pr); err != nil {
var prData DSLData
if err = json.Unmarshal(prJSON, &prData); err != nil {
return DSL{}, err
}
return pr, nil
return prData.ToInterface(), nil
}

func Process(command string, args []string) error {
Expand Down
Loading