Skip to content

Fix crash at milestone.dueOn#119

Merged
f-meloni merged 5 commits intodanger:masterfrom
anton46:master
Aug 31, 2020
Merged

Fix crash at milestone.dueOn#119
f-meloni merged 5 commits intodanger:masterfrom
anton46:master

Conversation

@anton46
Copy link
Contributor

@anton46 anton46 commented Aug 31, 2020

The crash happened when a PR has a milestone but the due-date has not been set.

com.squareup.moshi.JsonDataException: Non-null value 'dueOn' was null at $.danger.github.issue.milestone.due_on
	at com.squareup.moshi.kotlin.reflect.KotlinJsonAdapter.fromJson(KotlinJsonAdapter.kt:86)
	at com.squareup.moshi.JsonAdapter$2.fromJson(JsonAdapter.java:137)

Object documentation, https://docs.github.com/en/graphql/reference/objects#milestone

@anton46 anton46 changed the title Fix crash on milestone.dueOn Fix crash at milestone.dueOn Aug 31, 2020
Copy link
Member

@f-meloni f-meloni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, I was just making a new release, this change will go into that one then should be out soon :)

@danger-public
Copy link

Warnings
⚠️ Big PR, try to keep changes smaller if you can

Generated by 🚫 Danger Kotlin against d2192ea

@f-meloni f-meloni merged commit e1c954b into danger:master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants