Skip to content

Conversation

@f-meloni
Copy link
Member

No description provided.

@f-meloni f-meloni merged commit 327a278 into master Jan 29, 2022
@f-meloni f-meloni deleted the f-meloni-patch-20 branch January 29, 2022 20:04
@colejd
Copy link

colejd commented Sep 29, 2022

Hello! @f-meloni, when you get a chance, could you please explain why you removed this? Is there a technical limitation with Mint that prevents Danger from working with it? I know SPM presents some limitations sometimes, and all you can do is hope Apple fixes it someday - otherwise, I'd like to get a PR going for you to fix the issue if it's possible.

@f-meloni
Copy link
Member Author

Hi @colejd, sure!
Danger is made of two parts, one is a binary and one is a swift library that is linked when the Dangerfile is compiled in order to make the compiler resolve the Danger specific symbols (warn, message, Danger(), etc.).
Mint only installs the bin part, so when you go to compile the Dangerfile, that compilation fails.
There are probably some workarounds you can adopt to get the library from SPM, but they require a Package.swift, and if you have a Package.swift you can just use swift run danger-swift

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants