7 jellyfin unable to convert any images to local#8
Merged
daniel-widrick merged 3 commits intomainfrom Mar 3, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Addresses Jellyfin failures to fetch/convert program artwork by rewriting defunct zap2it image hosts and allowlisting the replacement host in the image proxy.
Changes:
- Add scrape progress logging for each 6-hour grid fetch.
- Rewrite
zap2it.tmsimg.comprogram image URLs totmsimg.comduring scrape output generation. - Allow
tmsimg.comin the image proxy allowlist.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1067
to
+1081
| fixed := 0 | ||
| for i := range programs { | ||
| if programs[i].IconSrc != "" && strings.Contains(programs[i].IconSrc, "zap2it.tmsimg.com") { | ||
| programs[i].IconSrc = strings.Replace(programs[i].IconSrc, "zap2it.tmsimg.com", "tmsimg.com", 1) | ||
| fixed++ | ||
| } | ||
| for j := range programs[i].Images { | ||
| if strings.Contains(programs[i].Images[j].URL, "zap2it.tmsimg.com") { | ||
| programs[i].Images[j].URL = strings.Replace(programs[i].Images[j].URL, "zap2it.tmsimg.com", "tmsimg.com", 1) | ||
| } | ||
| } | ||
| } | ||
| if fixed > 0 { | ||
| log.Printf("Fixed %d zap2it image URLs to use tmsimg.com", fixed) | ||
| } |
There was a problem hiding this comment.
The "Fixed %d zap2it image URLs" log only increments for IconSrc rewrites, but Images[*].URL rewrites are not counted. This makes the log misleading; either include image rewrites in the counter or adjust the message to reflect what is being counted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.