test(query): unit-test MySqlReadOnlySessionEnforcer#118
Merged
Conversation
MySQL has real session-level read-only enforcement (PR #109), but the repo has no MySQL Testcontainer so every line of the enforcer was unreachable — that accounted for ~1.8pp of the recent codecov drop. Two halves of the contract get pinned: Apply / Reset send the expected SET SESSION TRANSACTION READ {ONLY,WRITE} commands. A minimal RecordingDbConnection / RecordingDb- Command pair captures every command text that the enforcer's Execute helper sends — no real provider needed. IsReadOnlyViolation recognises MySQL's ER_CANT_EXECUTE_IN_READ_ONLY_TRANSACTION via reflection on the runtime exception's Number property. The fake mimics MySqlException by exposing a public int Number, so the reflection path executes exactly as in production. Tests cover: Number == 1792 → true, Number in {1, 1062, 2006} → false, DbException without a Number property → false (the property lookup returns null and the predicate falls through), non- DbException → false. No source changes — the enforcer is reached via the InternalsVisibleTo added in PR #115.
daniel3303
added a commit
that referenced
this pull request
May 27, 2026
…119) Oracle's SET TRANSACTION READ ONLY is per-transaction and an embedded COMMIT escapes it (see PR #110), so the enforcer is intentionally a no-op that only exposes a Limitation message — same shape as the SQL Server enforcer. With no Oracle Testcontainer in the repo every line of the enforcer was unreachable, accounting for ~1.6pp of the recent codecov drop. Pins the same contract as the SQL Server tests with one Oracle-specific twist: the Limitation message must explain why per-transaction read- only is the wrong layer of defense (the SQL Server message has no equivalent caveat to assert). 9 cases: Limitation non-null and mentions Oracle, explains the per-transaction gap (contains "transaction" / "COMMIT" / "session- level"), recommends a concrete remediation (SELECT, READ ONLY, or ALTER DATABASE), Apply and Reset send no commands (NSubstitute DidNotReceive on CreateCommand), IsReadOnlyViolation returns false for every shape of exception, Instance is a singleton. Closes the 5-PR coverage-recovery series (#115, #116, #117, #118, this PR). Combined recovery target ~7pp. No source changes — the enforcer is reached via the InternalsVisibleTo added in PR #115.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fourth in the 5-PR coverage-recovery series (after #115, #116, #117). MySQL has real session-level read-only enforcement (PR #109) but no MySQL Testcontainer in the repo, so every line of the enforcer was unreachable — that accounted for ~1.8pp of the recent codecov drop.
Two halves of the contract get pinned:
(a) Apply / Reset send the expected commands. A minimal
RecordingDbConnection/RecordingDbCommandpair (aDbConnectionsubclass with all the abstract members stubbed) captures every command text the enforcer'sExecutehelper sends. No real provider needed, no fragile NSubstitute dance — just a directly-callable test double.(b)
IsReadOnlyViolationrecognises MySQL'sER_CANT_EXECUTE_IN_READ_ONLY_TRANSACTIONvia reflection. The fake exception class mimicsMySqlExceptionby exposing a publicint Numberproperty, so the reflection-by-name lookup in the enforcer executes exactly as it would in production. Tests cover:DbExceptionsubclass withNumber == 1792trueDbExceptionsubclass withNumber ∈ {1, 1062, 2006}falseDbExceptionsubclass without aNumberpropertyfalse(reflection lookup returns null)InvalidOperationException(not a DbException)falseCode changes
tests/Equibles.AgentQL.UnitTests/Query/ReadOnly/MySqlReadOnlySessionEnforcerTests.cs(new) — 9 test cases plus the minimalDbConnection/DbCommandtest doubles.9 / 9 pass. No source changes — the enforcer is reachable via the
InternalsVisibleToadded in PR #115.