Integrated VBOs with staging system #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR integrates Vertex Buffer Objects (VBOs) with a new staging system, fundamentally refactoring how vertex data is managed in the rendering pipeline. The changes migrate from transform feedback-based particle updates to compute shader-based updates, and unify buffer management through a staged buffer architecture.
Key Changes:
- Refactored VBO to extend StagedBuffer instead of BufferObject, enabling unified buffer management
- Migrated particle and weather systems from transform feedback to compute shaders
- Renamed buffer-related methods for consistency (stride→vertexStride, buffer→mainBuffer, etc.)
- Simplified buffer memory layout enums by removing INTERLEAVED and SHARED variants
- Enhanced error handling with boolean return values for resize operations
Reviewed changes
Copilot reviewed 53 out of 53 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| regen/shader/shader-input.h/cpp | Renamed methods and added staged buffer support; core API changes for buffer management |
| regen/memory/vbo.h/cpp | Major refactoring: VBO now extends StagedBuffer; removed interleaved/sequential allocation logic |
| regen/memory/vertex-buffer.h/cpp | Deleted files - functionality merged into VBO and StagedBuffer |
| regen/memory/buffer-enums.h/cpp | Removed VERTEX_LAYOUT enum; added BufferComputeMode and PACKED_BASE_ALIGNMENT constant |
| regen/memory/client-buffer.cpp | Improved error handling and fixed resize logic for segmented buffers |
| regen/objects/mesh.h/cpp | Updated to use new VBO API; changed vaoAttributes_ from list to vector |
| regen/objects/particles.cpp | Migrated from transform feedback to compute shader-based particle updates |
| regen/shader/regen/weather/*.glsl | Converted particle update shaders from vertex shaders to compute shaders |
| regen/shader/regen/particles/emitter.glsl | Converted particle emitter from vertex shader to compute shader |
| regen/animation/mesh-animation.cpp | Refactored to use compute shaders for mesh interpolation |
| applications/scene-display/examples/*.xml | Updated particle configurations to specify std430 layout |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
✅ Compilation - SUCCESS! ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates Vertex Buffer Objects (VBOs) with a new staging system, fundamentally refactoring how vertex data is managed in the rendering pipeline. The changes migrate from transform feedback-based particle updates to compute shader-based updates, and unify buffer management through a staged buffer architecture.