Add ser_context::end() function #395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for contributing. Could you rename |
- position() also reports start of elements that are not values (e.g. "{" or "[")
- end_position() reports the end of the element
wbangna
force-pushed
the
ser_context_with_end
branch
from
07c4df2 to
41ad21d
Compare
Contributor
Author
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the usage of the function
ser_context::position()to be usable for other elements reported to the visitor (e.g.start_array,end_arrayetc.).It also introduces the function
ser_context::end()which reports the end position of the currently parsed element.To test the new functionality use the following test program: https://gist.github.com/wbangna/03bc656af36c50d6479f166f34981682
I did not change the documentation yet as I am not sure if the functionality changes of
ser_context::position()will be accepted.