Skip to content

Conversation

@ergonjomeier
Copy link
Contributor

After updating to 0.171.0, our code failed to compile with the following error:

.../jsoncons/basic_json.hpp:3866:13: error: no matching member function for call to 'dump_pretty' dump_pretty(cont, options, indent, ec);

The error occurs because on line 3866, dump_pretty is called with 4 parameters, but a dump_pretty function with the corresponding signature does not exists. After looking into the issue (and reading the doc https://github.com/danielaparker/jsoncons/blob/master/doc/ref/corelib/json/dump.md), I think that a dump_pretty function that takes an indent parameter should not exist at all.

I am not entirely sure how to fix this. The docs say that there should be a dump_pretty function that takes a CharContainer and options, with the options having a default parameter. My proposition changes the functions signature to fit the docs.

@danielaparker danielaparker merged commit 3498366 into danielaparker:master Jul 14, 2023
@danielaparker
Copy link
Owner

Thanks for fixing this!

@ergonjomeier
Copy link
Contributor Author

Glad I could help :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants