Don't run duplicate build workflows on PRs and protect secrets#54
Merged
danielchalmers merged 4 commits intomainfrom Nov 1, 2025
Merged
Conversation
Removed description for ENABLE_SIGNING input.
Removed ENABLE_SIGNING option from full-build action.
danielchalmers
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Android build process to support conditional signing based on an ENABLE_SIGNING flag. The changes allow unsigned builds for development/CI workflows while maintaining signed builds for production deployments.
- Introduced an
ENABLE_SIGNINGinput parameter to control whether Android builds should be signed - Made signing-related inputs (
RELEASE_KEYSTORE_BASE64andRELEASE_KEYSTORE_PASS) optional instead of required - Split the Android build step into separate signed and unsigned build paths based on the signing flag
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/actions/full-build/action.yml |
Added ENABLE_SIGNING input, made keystore inputs optional, and implemented conditional build steps for signed vs unsigned builds |
.github/workflows/deploy.yml |
Enabled signing for deployment workflow by passing ENABLE_SIGNING: true |
.github/workflows/build.yml |
Removed signing-related secrets and simplified build workflow to only trigger on main branch; signing disabled by default |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| required: true | ||
| required: false | ||
| default: "" | ||
| ENABLE_SIGNING: |
There was a problem hiding this comment.
The ENABLE_SIGNING input is missing a description field. All inputs should have descriptive documentation to help users understand their purpose. Consider adding: description: 'Enable APK signing for production builds'
Suggested change
| ENABLE_SIGNING: | |
| ENABLE_SIGNING: | |
| description: "Enable APK signing for production builds" |
danielchalmers
deleted the
codex/remove-overlapping-pr-and-build-workflows
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_69066d442ac083289cb4d6ecd8a4cb31