Added option to append a string to the source's ID and set the ID att… #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ribute on the element
wagedomain
added a commit
that referenced
this pull request
Jan 16, 2016
Added new option: appendId. This allows a mapping of a label to the combobox for accessibility compliance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support accessibility, specifically associating a label with the rendered combobox, I added an 'appendId' option to the 'options' that if specified, it will use the source's id, append the value of the option, and add the resulting string as the rendered combobox's id. This allows proper linkage of a label to the combobox via the label's 'for' attribute.