This commit introduces support for calling functions within expressions.#12
Merged
danielgtaylor merged 4 commits intodanielgtaylor:mainfrom Apr 22, 2026
Conversation
The key changes are:
- Interpreter:
- Added a new `NodeFunctionCall` AST node to represent a function call.
- The interpreter can now execute functions passed in the variables map. It supports
functions with 0 to 3 parameters of type `any`.
- Implemented short-circuiting for `AND` and `OR` logical operators.
- Parser:
- The parser now recognizes function call syntax (`identifier(...)`).
- It can parse comma-separated arguments in function calls.
- Lexer:
- Added a `TokenComma` to tokenize function argument lists.
- Conversions:
- Type conversion functions now handle `func()` types, allowing for lazy evaluation
of values.
- Testing:
- Added a comprehensive test suite for the new function call functionality.
vrancurel
force-pushed
the
vrancurel/first_class_function_support
branch
from
c2b04d0 to
fd5b4ca
Compare
danielgtaylor
approved these changes
Apr 22, 2026
Owner
danielgtaylor
left a comment
danielgtaylor
left a comment
There was a problem hiding this comment.
LGTM, thanks! I made a few changes to support more function types via reflection, but the interface to use this feature remains the same as your original PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The key changes are:
NodeFunctionCallAST node to represent a function call.any.ANDandORlogical operators.identifier(...)).TokenCommato tokenize function argument lists.func()types, allowing for lazy evaluation of values.