Improve parser and interpreter performance#15
Merged
danielgtaylor merged 2 commits intomainfrom Apr 24, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR focuses on improving performance in the expression engine by reducing allocations and adding benchmarks to track key hot paths across lexing, parsing, and evaluation.
Changes:
- Reduced allocations by reusing lexer token storage and avoiding interface indirection in parser construction.
- Added fast paths for slice
.lengthevaluation and primitive equality checks. - Introduced internal benchmarks to measure common expression/utility performance.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| typecheck.go | Reuses shared option parsing to avoid repeated option scanning. |
| parser.go | Avoids interface calls when using the concrete lexer; supports generic lexers as fallback. |
| lexer.go | Reworks token allocation/caching and avoids per-token rune counting in hot paths. |
| interpreter.go | Adds bound-normalization helpers and a fast path for slice .length. |
| functions.go | Adds a fast-path switch to avoid reflection when resolving non-lazy values. |
| expr.go | Centralizes option parsing and constructs lexer/parser/interpreter/typechecker with fewer allocations. |
| conversions.go | Adds fast paths for deep equality of numbers/strings/bools (including lazy funcs). |
| benchmark_test.go | Adds focused internal benchmarks for lexer, lazy-value resolution, and equality checks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
go test ./...