Ignore io.WriteString results in Format#51
Merged
Conversation
Assign io.WriteString's return values to blank identifiers in Untrusted.Format to explicitly ignore them. This silences linters/tools (e.g., errcheck) that flag unchecked return values when writing the fixed string.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Untrusted.Format implementation used in passlint analysistest data to explicitly ignore io.WriteString return values, preventing linters (e.g., errcheck) from flagging the call as unchecked.
Changes:
- Assign
io.WriteString’s(int, error)return values to blank identifiers inUntrusted.Formatto make the intentional ignore explicit.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assign io.WriteString's return values to blank identifiers in Untrusted.Format to explicitly ignore them. This silences linters/tools (e.g., errcheck) that flag unchecked return values when writing the fixed string.
What
Describe the change in a few sentences.
Why
Explain the problem, user need, or maintenance reason.
Testing
make fmtmake vetmake lintGOWORK=off go test ./...Safety