-
Notifications
You must be signed in to change notification settings - Fork 0
fix: apply PR #2 review feedback - CodeQL auto-detection, docs accuracy #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: danielnovais-tech <230455320+danielnovais-tech@users.noreply.github.com>
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Follow-up to PR #2 to align automation configuration and documentation, focusing on CodeQL language selection, label keyword mappings, and minor workflow/config consistency updates.
Changes:
- Updated CodeQL workflow intent from hardcoded language matrix to “auto-detection” and adjusted docs accordingly.
- Completed auto-label keyword lists/tables in
docs/AUTOMATION.md(includingupdate package). - Tweaked automation configs for consistency (Go
1.21.x, Dependabot commit message prefixing, PR template reviewer placeholder).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
docs/AUTOMATION.md |
Updates CodeQL and auto-label documentation/keyword lists to match workflow behavior and reviewer feedback. |
.github/workflows/codeql.yml |
Removes hardcoded language matrix and category, aiming for auto-detected scanning. |
.github/workflows/ci.yml |
Uses 1.21.x for Go toolchain patch flexibility. |
.github/pull_request_template.md |
Replaces dangling @ with a clearer reviewer placeholder. |
.github/dependabot.yml |
Adds prefix-development: "chore" to Docker and Go module ecosystems for consistency. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Initialize CodeQL | ||
| uses: github/codeql-action/init@v3 | ||
| with: | ||
| languages: ${{ matrix.language }} | ||
| # If you want to specify queries, uncomment below | ||
| # queries: security-and-quality | ||
| # Languages are automatically detected based on repository contents | ||
| # Supported: 'cpp', 'csharp', 'go', 'java', 'javascript', 'python', 'ruby', 'swift' |
Copilot
AI
Jan 23, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The github/codeql-action/init@v3 step no longer provides a with.languages input. The CodeQL init action expects explicit languages to analyze, so this workflow will fail at runtime rather than auto-detecting. Consider adding a lightweight detection step that outputs a comma-separated language list (or skips the job entirely when none are found) and pass that value to init.
| - Reports findings to Security tab | ||
|
|
||
| **Languages**: JavaScript, Python (automatically detected) | ||
| **Languages**: Automatically detected (supports C++, C#, Go, Java, JavaScript, Python, Ruby, Swift) |
Copilot
AI
Jan 23, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Within this doc, the CodeQL language description is now inconsistent: this section says languages are “automatically detected” and lists many languages, but later under Code Review Tools > CodeQL the doc still states “Languages: JavaScript, Python”. Update the later section (or consolidate to a single source of truth) so the document doesn’t contradict itself.
| **Languages**: Automatically detected (supports C++, C#, Go, Java, JavaScript, Python, Ruby, Swift) | |
| **Languages**: Automatically detected based on the CodeQL workflow configuration (currently JavaScript and Python) |
📋 Descrição
Follow-up to PR #2 addressing reviewer feedback on automation infrastructure. Fixes hardcoded CodeQL languages, documentation inaccuracies, and configuration inconsistencies.
O que mudou?
CodeQL Workflow (
.github/workflows/codeql.yml):language: ['javascript', 'python']matrixDocumentation (
docs/AUTOMATION.md):dependencies: addedupdate packageCI Workflow (
.github/workflows/ci.yml):'1.21'→'1.21.x'for patch version flexibilityDependabot (
.github/dependabot.yml):prefix-development: "chore"to Docker and Go modules ecosystems for consistency with npm/pip/actionsPR Template (
.github/pull_request_template.md):@→@reviewer-usernamePor quê?
Hardcoded languages in CodeQL contradict "automatic detection" claims in docs and prevent future language support. Documentation keyword tables were incomplete, missing several mappings actually used by auto-label workflow. Configuration inconsistencies across ecosystems reduce predictability.
✅ Checklist
🔗 Issue Relacionada
Addresses #2 (review)
🎯 Impacto Esperado
Áreas Afetadas
Impacto de Risco
📸 Capturas de Tela (se aplicável)
N/A - Configuration and documentation changes only
🧪 Como Testar
python3 -c "import yaml; yaml.safe_load(open('.github/workflows/codeql.yml'))"📝 Notas Adicionais
CodeQL auto-detection will analyze all supported languages found in repository (C++, C#, Go, Java, JavaScript, Python, Ruby, Swift) rather than limiting to JavaScript/Python. This makes the workflow future-proof as the repository evolves.
🔍 Revisores Sugeridos
@reviewer-username
Original prompt
This pull request was created from Copilot chat.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.