fix: Cmd+Q intercepted by tab cycling handler in useKeyboard#9
Open
cprivitere wants to merge 1 commit into
Open
fix: Cmd+Q intercepted by tab cycling handler in useKeyboard#9cprivitere wants to merge 1 commit into
cprivitere wants to merge 1 commit into
Conversation
cprivitere
changed the title
cprivitere
force-pushed
the
feat/cmd-q-quit
branch
from
78736e7 to
e754006
Compare
cprivitere
changed the title
The useKeyboard composable's tab cycling handler checked for bare 'q' without guarding against metaKey/ctrlKey, so Cmd+Q was being intercepted and treated as a 'previous tab' command instead of quitting the app.
cprivitere
force-pushed
the
feat/cmd-q-quit
branch
from
e754006 to
039d786
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
useKeyboardcomposable's tab cycling handler (src/composables/useKeyboard.ts:97) checked for bareqwithout guarding againstmetaKey/ctrlKey, soCmd+Qwas being intercepted and treated as a 'previous tab' command instead of quitting the app.Fix: wrap the
q/etab cycling shortcuts in!event.metaKey && !event.ctrlKeyso they only fire for unmodified keypresses.