Merged
Conversation
Add VISAGE_IOS=1 compile definition when building for iOS, detected before the existing APPLE check so iOS is distinguished from macOS.
This was referenced Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Series overview
This is the first in a series of 7 small, incremental PRs that add iOS
support to Visage, including multi-touch. Each builds on the previous one:
int pointer_id = 0to MouseEvent/Window)All changes are backward compatible — desktop platforms are completely
unaffected. These PRs are on my fork for now; happy to adjust the structure
or ordering before submitting upstream.
Summary
Add
VISAGE_IOScompile definition when building for iOS, detected before theexisting
APPLEcheck so iOS is distinguished from macOS.VISAGE_IOS=1whenCMAKE_SYSTEM_NAMEisiOSTest plan
VISAGE_IOSnot defined,VISAGE_MACstill setVISAGE_IOS=1defined,VISAGE_MACnot set