Added doom and cantina band#4
Merged
danilofuchs merged 3 commits intodanilofuchs:mainfrom Feb 19, 2021
Merged
Conversation
danilofuchs
requested changes
Feb 12, 2021
Owner
danilofuchs
left a comment
danilofuchs
left a comment
There was a problem hiding this comment.
Wow, such nice songs!
Why not™ should be the slogan here.
Doom song is playing awesomely!
I'm afraid my Macbook could not handle the higher pitched notes from Doom, and Cantina Band became a big mess 😄 .
I'll improve some things in the player as Doom requires tempo of 300 and the slider goes to 200 max.
Oh, and you should add these songs to the Readme file
Changed note padding Co-authored-by: Danilo Campana Fuchs <danilo_fuchs@hotmail.com>
Contributor
Author
|
There we go, I have added your changes and updated readme |
danilofuchs
approved these changes
Feb 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because you know, why not™