Extract Tier-1 state-owning hooks from App.tsx#56
Merged
Conversation
The commit checkbox map and its file/master/hunk toggles, discard-hunk and next-commit size move into components/changes/useCommitSelections — the slice owns its own state, App just composes it. Single-feature logic now lives with the Changes feature rather than in lib/.
fetch/pull/push/publish runner, the syncRunning flag and its determinate fill move into components/toolbar/useSyncActions, sitting with the SyncButton it drives. The branch switcher's fill (switching) stays in App since it keys off the checkout state the branch-op path owns, not sync.
useCommitLog and useCommitDetail are history-only, so they belong with the History feature rather than in lib/ (the shared tier). No import changes inside them — they only depend on @shared/types and react. CLAUDE.md now states the rule: a hook used by exactly one feature lives in that feature's folder; lib/ holds logic reused by 2+ features.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tier 1 of the App.tsx slimming
Continues the
App.tsxsplit, extracting only the slices that own their own state — the cuts that genuinely reduce App's responsibilities rather than relocating coupling behind a parameter bag. App stays the cross-feature orchestration spine.What moved
useCommitSelections→components/changes/— the commit checkbox map and its file/master/hunk toggles, discard-hunk, and the next-commit on-disk size. App composes it;setSelectionsis returned so the lifecycle paths (repo switch, checkout, commit, stash) can still reset it.useSyncActions→components/toolbar/— the fetch/pull/push/publish runner, thesyncRunningflag, and its determinate fill, sitting next to theSyncButtonit drives. The branch switcher'sswitchingfill stays in App (it keys off checkout state, not sync).useCommitLog/useCommitDetail→ moved fromlib/tocomponents/history/— they're history-only, so they belong with the feature.Convention
This establishes the rule (now in CLAUDE.md): a hook used by exactly one feature lives in that feature's folder;
lib/is the shared tier for logic reused by 2+ features.Deliberately not done
The orchestration spine (
refresh,runOp,applyRepo,switchTab,revealCommit, the loaders) stays in App — it's cross-feature by nature, and extracting it behind a param bag would relocate coupling, not remove it.App.tsx: 1610 → 1521 lines; the real win is cohesion, not line count.Verification
typecheck,lint, andbun test(543 pass) all green. Pure behavior-preserving moves with identical JSX — no live drive yet (no debug instance was running; a fresh launch would touch local recent-repos).