Skip to content

Conversation

@markus-willems
Copy link
Contributor

Some functions enter an infinite loop if applied with factorial numbers. This PR should fix this.

Specifically, the P function will not leave its loop if n is a number >1 that's a factorial number (1.1, 3.5, 6.87, ...).

Now, with this PR, it will throw RangeError if n is a factorial number.

Further, I added tests where needed as well as added new test suits for factorial and factoradic.

@dankogai dankogai merged commit e059179 into dankogai:master Nov 10, 2018
@dankogai
Copy link
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants