Skip to content

misra.py: Fix R12.4 crash on volatile macro argument #2654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danmar merged 1 commit into from
May 21, 2020
Merged

misra.py: Fix R12.4 crash on volatile macro argument #2654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions addons/misra.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1735,6 +1735,8 @@ def misra_12_4(self, data):
if (not isConstantExpression(token)) or (not isUnsignedInt(token)):
continue
for value in token.values:
if value.intvalue is None:
continue
if value.intvalue < 0 or value.intvalue > max_uint:
self.reportError(token, 12, 4)
break
Expand Down
2 changes: 2 additions & 0 deletions addons/test/misra/misra-test.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,6 +473,7 @@ void misra_12_3(int a, int b, int c) { // no warning

#define MISRA12_4a 2000000000u
#define MISRA12_4b 4000000000u
#define volatile_macro_12_4 (*(volatile U32 *) 0xFFFFFC10u)
void misra_12_4() {
uint32_t x;
bool t;
Expand All @@ -481,6 +482,7 @@ void misra_12_4() {
x = 0u - 1u; // 12.4
x = t ? 0u : (0u-1u); // 12.4
x = 556200230913ULL;
foo(&volatile_macro_12_4); // no crash
}

struct misra_13_1_t { int a; int b; };
Expand Down