Preprocessor: removed unreachable ConfigurationNotChecked finding#4790
Merged
danmar merged 1 commit intodanmar:mainfrom Mar 2, 2023
Merged
Preprocessor: removed unreachable ConfigurationNotChecked finding#4790danmar merged 1 commit intodanmar:mainfrom
ConfigurationNotChecked finding#4790danmar merged 1 commit intodanmar:mainfrom
Conversation
Collaborator
Author
|
The removed tests were feeding impossible data into the preprocessor. They use a custom |
firewave
added a commit
to firewave/cppcheck
that referenced
this pull request
Mar 24, 2026
…inding (danmar#4790)" [skip ci] This reverts commit 3813616.
firewave
added a commit
to firewave/cppcheck
that referenced
this pull request
Mar 24, 2026
…inding (danmar#4790)" [skip ci] This reverts commit 3813616.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The finding can never be triggered
Preprocessor::validateCfg()bails out when the define contains a=(e.g.DEF_1=1).I came across this as I was trying to write a unit test for this and failed to trigger this.
cfgis generated by callingPreprocessor::createDUI(). That callssplitcfg(mSettings.userDefines, dui.defines, "1")to generate that config but as the last parameter shows it will set a default value of1if it is not specified. So it is not possible to generate a configuration which contains defines without any values andPreprocessor::validateCfg()will not be able to report any warnings.I assume the configuration string was changed at some point rending that validation void.