CppCheck: small AnalyzerInformation usage cleanup
#6634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I was trying to make the object local instead of a class member but as it is being used by Even I did not achieve that goal the usage checks got more explicit instead of relying on |
Collaborator
Author
|
I think I might need to add some builddir-related tests first. |
This comment was marked as outdated.
This comment was marked as outdated.
firewave
force-pushed
the
anainfo-2
branch
3 times, most recently
from
2520d19 to
44d81e2
Compare
danmar
reviewed
Dec 3, 2024
|
|
||
| if (!mSettings.buildDir.empty()) { | ||
| mAnalyzerInformation.close(); | ||
| if (mAnalyzerInformation) { |
Owner
There was a problem hiding this comment.
Nit: I guess we don't need the condition. We can just reset directly and let it check internally..?
Collaborator
Author
There was a problem hiding this comment.
Makes sense - but I intentionally kept it intact for now. The future refactorings might get rid of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.