Skip to content

Conversation

@firewave
Copy link
Collaborator

No description provided.

@firewave firewave changed the title refs #12274 - test/cli/proj_2_test.py: made it location-independent / some cleanups refs #12274 - test/cli/proj2_test.py: made it location-independent / some cleanups Jul 24, 2024
@firewave

This comment was marked as resolved.

@firewave firewave marked this pull request as draft July 24, 2024 08:55
@firewave

This comment was marked as resolved.

@firewave
Copy link
Collaborator Author

firewave commented Aug 4, 2024

There is still an issue that a Windows binary somehow reports an absolute path where a Linux one doesn't:

FAILED proj2_test.py::test_gui_project_loads_absolute_vs_solution_2 - AssertionError: assert 'D:\\a\\cppcheck\\cppcheck\\test\\cli\\proj2\\a\\a.c:1:7: error: Division by zero. [zerodiv]\nx = 3 / 0;\n      ^\nD:\\a\\cppcheck\\cppcheck\\test\\cli\\proj2\\b\\b.c:1:7: error: Division by zero. [zerodiv]\nx = 3 / 0;\n      ^\n' == 'a\\a.c:1:7: error: Division by zero. [zerodiv]\nx = 3 / 0;\n      ^\nb\\b.c:1:7: error: Division by zero. [zerodiv]\nx = 3 / 0;\n      ^\n'
  
  - a\a.c:1:7: error: Division by zero. [zerodiv]
  + D:\a\cppcheck\cppcheck\test\cli\proj2\a\a.c:1:7: error: Division by zero. [zerodiv]
    x = 3 / 0;
          ^
  - b\b.c:1:7: error: Division by zero. [zerodiv]
  + D:\a\cppcheck\cppcheck\test\cli\proj2\b\b.c:1:7: error: Division by zero. [zerodiv]
    x = 3 / 0;
          ^

@firewave

This comment was marked as outdated.

@firewave
Copy link
Collaborator Author

firewave commented Oct 30, 2024

There is still an issue that a Windows binary somehow reports an absolute path where a Linux one doesn't:

This was an issue with relative paths and a missing path conversation when reading a .cppcheck project compared to what the CLI is doing.

@firewave firewave marked this pull request as ready for review October 30, 2024 13:35
@firewave firewave changed the title refs #12274 - test/cli/proj2_test.py: made it location-independent / some cleanups refs #12274 / fixed #13287 - test/cli/proj2_test.py: made it location-independent / some cleanups Oct 30, 2024
@firewave
Copy link
Collaborator Author

No feedback for two weeks - merging.

@firewave firewave merged commit 9130b3b into danmar:main Nov 13, 2024
60 checks passed
@firewave firewave deleted the py-xxx branch November 13, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant