Fix #13425 (simplecpp: bump to 1.2.0) #7103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmar
changed the title
alleonik
reviewed
May 21, 2025
| TokenList tokensB(files); | ||
| const Token *nextTok = B->next; | ||
|
|
||
| if (canBeConcatenatedStringOrChar) { |
There was a problem hiding this comment.
unexpectedA is defined as ... && !canBeConcatenatedStringOrChar => here if(unexpectedA) will never be executed.
Owner
Author
There was a problem hiding this comment.
hmm it's true. I don't have a strong opinion. technically it can't be executed. maybe it was added as an extra safety check if one considers these variables separately mentally. and we could update the unexpectedA condition later..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.