Fix #13236: False positive: unusedFunction reported when SLOT() is used in qt code #7270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfg/qt.cfg
Outdated
| <define name="SIGNAL(X)" value="#X"/> | ||
| <define name="SLOT(X)" value="#X"/> | ||
| <!-- <define name="SIGNAL(X)" value="#X"/> --> | ||
| <!-- <define name="SLOT(X)" value="#X"/> --> |
Collaborator
There was a problem hiding this comment.
Won't this cause checkLibraryFunction warnings? Can we define value="X"?
Collaborator
Author
There was a problem hiding this comment.
Yes. That's a good idea
danmar
approved these changes
Jan 30, 2025
Owner
There was a problem hiding this comment.
I am unsure if we want to mark these somehow to indicate that they are not function calls.. the testcode will be preprocessed to QObject::connect(this , doStuff(), doStuff());
Something like:
<define name="SIGNAL(X)" value="__cppcheck__(X)"/>
<define name="SLOT(X)" value="__cppcheck__(X)"/>
But imho we can implement that later if we see real problems with your SIGNAL/SLOT macros..
firewave
reviewed
Jan 30, 2025
| namespace { | ||
| class TestUnusedFunction : public QObject { // #13236 | ||
| TestUnusedFunction(); | ||
| // cppcheck-suppress functionStatic |
Collaborator
There was a problem hiding this comment.
We can avoid this by adding (void)this to the body.
firewave
reviewed
Jan 30, 2025
| QObject::connect(this, SIGNAL(doStuff()), SLOT(doStuff())); | ||
| } | ||
|
|
||
| void TestUnusedFunction::doStuff() {} // Should not warn here with unusedFunction |
Collaborator
There was a problem hiding this comment.
We should also add a method which triggers unusedFunction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.