filesettings.h: removed constructors without language #7493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| : FileWithDetails(std::move(path), Standards::Language::None, 0) | ||
| {} | ||
|
|
||
| FileWithDetails(std::string path, Standards::Language lang, std::size_t size) |
Collaborator
There was a problem hiding this comment.
Maybe size = 0 should be the default?
Collaborator
Author
There was a problem hiding this comment.
I would like to have it mandatory since the application code should not omit it without a good reason.
Collaborator
There was a problem hiding this comment.
It seems to be always 0 though, except in the new tests.
Collaborator
Author
There was a problem hiding this comment.
That is because it was not accidentally omitted in the application code.
Collaborator
Author
There was a problem hiding this comment.
Maybe this can be cleaned up with the draft changes to the size handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.