-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fixed #13829 - mapped bugprone-* clang-tidy findings to warning
#7503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Requires #7502 to be merged first. |
|
|
Fair enough. But we should at least map them to |
lib/cppcheck.cpp
Outdated
| errmsg.severity = Severity::performance; | ||
| else if (startsWith(id, "portability-")) | ||
| errmsg.severity = Severity::portability; | ||
| else if (startsWith(id, "cert-") || startsWith(id, "misc-") || startsWith(id, "unused-")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last one needs to check if the ID contains -unused-.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
bugprone-* clang-tidy findings to errorbugprone-* clang-tidy findings to warning
Done. |
|
Ugh - I messed up the separate commits. But should be fine. |
No description provided.