TestStl: cleaned up settings usage #7930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
firewave
commented
Oct 29, 2025
Comment on lines
-190
to
+192
| const Settings settings1 = settingsBuilder(settings).certainty(Certainty::inconclusive, options.inconclusive).cpp(options.cppstandard).build(); | ||
| const Settings* s = options.s ? options.s : (options.inconclusive ? &settings_i : &settings); |
Collaborator
Author
There was a problem hiding this comment.
inconclusive is not applied to custom settings but I think that is fine. We could add a sanity check (or overload) to make sure that nothing is supplied with the custom settings - but that applies across all tests and so is out-of-scope for this PR.
Collaborator
Author
|
This saves another 30 seconds to in slow running tests in the CI. |
danmar
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.