Fix #13825 (toomanyconfigs lacks file information) #7967
Conversation
|
Looks like we are lacking tests for this (and |
Yeah I was expecting some testfailures |
danmar
changed the title
test/cli/other_test.py
Outdated
| f.write(f'#{dir} defined(X{i})\nx = {i};\n') | ||
| f.write('#endif\n') | ||
|
|
||
| args = ['--enable=information', '--template=daca2', str(test_file)] |
There was a problem hiding this comment.
Why are using the daca2 template?
There was a problem hiding this comment.
because default template writes 3 lines instead of 1.
There was a problem hiding this comment.
any 1-line template format will do here imho
There was a problem hiding this comment.
simple is usually used in the tests.
| // if maxConfigs has default value then report information message that configurations are skipped | ||
| if (mSettings.maxConfigs == 12 && mSettings.severity.isEnabled(Severity::information)) | ||
| tooManyConfigsError(Path::toNativeSeparators(file.spath()), configurations.size()); | ||
|
|
There was a problem hiding this comment.
This feels very strange.
Also the check for the default value should not be hard-coded - use a default Settings object to check against.
There was a problem hiding this comment.
I wrote a comment to describe it.
There was a problem hiding this comment.
Thanks. Seems to make sense but I have not thought too much about it - as I have not dug too much into #7424.
But I have to from a different angle anyways as part of preprocessor work I am doing. But merging this should be fine (possibly even helpful as there is less code to go through).
|
2 participants
The file-less warning generated from cppcheckexecutor.cpp is removed. the --errorlist message should match the real message.