Skip to content

Remove erroneous comments about duplicates [skip ci]#8405

Merged
firewave merged 4 commits intodanmar:mainfrom
chrchr-github:chr_dupl
Apr 2, 2026
Merged

Remove erroneous comments about duplicates [skip ci]#8405
firewave merged 4 commits intodanmar:mainfrom
chrchr-github:chr_dupl

Conversation

@chrchr-github
Copy link
Copy Markdown
Collaborator

No description provided.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 2, 2026

@firewave
Copy link
Copy Markdown
Collaborator

firewave commented Apr 2, 2026

To provide some context how these came to be.

In the past we did not emit duplicates in tests. When that restriction was removed we did not yet emit the column in the messages so they did look like duplicates at that point.

@firewave
Copy link
Copy Markdown
Collaborator

firewave commented Apr 2, 2026

FYI if you want to prevent the PR from running the build you also need to flag the latest commit. But I assume this was intentional to check if the changes are fine and to avoid a build on merge.

@chrchr-github
Copy link
Copy Markdown
Collaborator Author

FYI if you want to prevent the PR from running the build you also need to flag the latest commit. But I assume this was intentional to check if the changes are fine and to avoid a build on merge.

Yeah, let's say it was intentional and I didn't forget about the individual commits...

@firewave firewave merged commit c0d6206 into danmar:main Apr 2, 2026
72 checks passed
@chrchr-github chrchr-github deleted the chr_dupl branch April 2, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants