CI-unixish.yml: specify proper define for "safe libc++"#284
Merged
danmar merged 1 commit intodanmar:masterfrom Jan 2, 2023
Merged
CI-unixish.yml: specify proper define for "safe libc++"#284danmar merged 1 commit intodanmar:masterfrom
danmar merged 1 commit intodanmar:masterfrom
Conversation
firewave
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I followed the documentation from https://libcxx.llvm.org/DesignDocs/DebugMode.html#using-the-debug-mode which refers to
LIBCXX_ENABLE_DEBUG_MODE. But that is a CMake define you are supposed to pass when buildinglibc++. Also the debug mode needs the library to be built with it which is not something we do. So as suggested we should enable the assertions via_LIBCPP_ENABLE_ASSERTIONS=1instead - see https://libcxx.llvm.org/UsingLibcxx.html#assertions-mode.