Skip to content

Misc updates#231

Merged
danmarshall merged 10 commits intodanmarshall:masterfrom
jstaab:pr1
Apr 1, 2022
Merged

Misc updates#231
danmarshall merged 10 commits intodanmarshall:masterfrom
jstaab:pr1

Conversation

@jstaab
Copy link
Copy Markdown
Contributor

@jstaab jstaab commented Feb 23, 2022

A collection of small touch-ups I've collected over time. Just running down a commit summary:

  • Removes math.gl and luma.gl types because they now have their own
  • Adds "_containerRef" to the DeckGL class
  • LayerManager returns Layer<any, any> to better match all Layers.
  • Uses math.gl's Matrix4 for instances of modelMatrix
  • Adds animationLoop, eventManager, layerManager, tooltip to Deck class
  • Adds "el" to the Tooltip class
  • Extracts an "InteractionState" type and uses it accordingly
  • Re-adds the "id" parameter to Scatterplot.getShaders

@danmarshall
Copy link
Copy Markdown
Owner

This is really cool, thanks a lot. I'm wondering if removing changes to math.gl references should warrant a breaking change for us, that we would bump the major version number.

@jstaab
Copy link
Copy Markdown
Contributor Author

jstaab commented Feb 24, 2022

Thanks for the welcome here! I think it's a good point about bumping the version, as some users could still be on the typeless math.gl and luma.gl packages.

But on that subject, I've got another PR waiting (I wanted to get these commits out of the way first) that adds Non-Iterable data support, type inference, extension props. It may make more sense, if we're thinking version bumps anyway, to go ahead and fold these commits in to it after all.

I'll go ahead and make that new PR and we can figure out what to do with this one, based on what you think of it.

@jstaab
Copy link
Copy Markdown
Contributor Author

jstaab commented Mar 8, 2022

Was thinking another way forward, maybe less intrusive, would be to just push the typings overlap fix for luma.gl and math.gl down the road and remove 508fba4. Would that be better?

@danmarshall
Copy link
Copy Markdown
Owner

@jstaab seems like a sound idea - if it's not too much work for you.

@jstaab
Copy link
Copy Markdown
Contributor Author

jstaab commented Apr 1, 2022

@danmarshall should be ready for a review

@danmarshall danmarshall merged commit 12e9f48 into danmarshall:master Apr 1, 2022
@danmarshall
Copy link
Copy Markdown
Owner

Thanks! Published 4.9.20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants