Skip to content

Remove limit on logs. #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dannyhp1 merged 3 commits into from
Dec 3, 2019
Merged

Remove limit on logs. #14

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8479490
Added comments/TODO for download method.
dannyhp1 Dec 2, 2019
4b2605e
Removed limit on amount of logs displayed to user.
dannyhp1 Dec 3, 2019
e2c8be4
Merge branch 'master' into develop
dannyhp1 Dec 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/App/App.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,9 @@ class App extends Component {
})
}

/**
* Downloads the currently displayed source code to the user's desktop.
*/
downloadCode = () => {
// TODO: Code to download source code.
}
Expand All @@ -164,14 +167,9 @@ class App extends Component {
// Before processing the new result, we must pop the message 'Running your code...' off and re-enable the button.
this.setFinishedStatus()

// Will only keep the latest 10 results in the logs.
// TODO: Keep only a specific amount of logs.
let currentResults = this.state.results

// Most recent results are at the top, remove the element at the end if we exceed 10 logs.
if (currentResults.length >= 10) {
currentResults.pop()
}

if (result['build'] === true) {
currentResults.unshift('[' + languages[this.state.language] + '] Build successfully completed!\nStandard output:\n' + result['message'])
} else {
Expand Down